Add plan parent-reduction rule API - #9196
Draft
joseph-isaacs wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Hooray! CodSpeed harness just leveled up!The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable. What changed between base and head:
Re-run the base with the same settings to get a valid performance comparison. Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanParentReduceRuleAPI for child-driven physical-plan rewritesPlanParentRuleSetwhose first successful rewrite winsvortex_layout::plan::optimizerStack
This draft is stacked on #9142 and targets
vortex-plan.The concrete expression optimization rules are intentionally excluded and live in #9166, which is stacked on this PR.
Scope
This PR only introduces the rule framework and APIs. It registers no concrete rules and does not change optimization behavior.
Checks
cargo test -p vortex-layout— 211 passedcargo clippy -p vortex-layout --all-targets --all-features -- -D warningscargo +nightly fmt --all -- --checkgit diff --check